-
-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for loading images in the K3s module #1622
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added just two minor comments, although the one regarding the new PullImage method would need your attention.
Other than that, this PR LGTM, thank you very much for your work here 👏
7847331
to
bc2a01a
Compare
I added some documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a few comments, all minor.
Thank you so much for your contribution including testable examples in his to load the images into the cluster. Very helpful!
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
3ff2311
to
f0791ac
Compare
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
Lint failed: I think you can run |
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Following a conversation with @mdelapenya The As a result of these simplifications, the |
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your time contributing to testcontainers-go! 👏
…util/v3-3.23.8 * main: chore(deps): bump github.com/IBM/sarama in /modules/kafka (#1637) chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (#1625) chore(deps): bump github.com/elastic/go-elasticsearch/v8 (#1641) chore(deps): bump github.com/tidwall/gjson from 1.16.0 to 1.17.0 in /modules/couchbase and /modules/vault (#1684) chore(deps): bump mkdocs from 1.5.2 to 1.5.3 (#1662) chore(deps): bump github.com/nats-io/nats.go in /modules/nats (#1657) chore(deps): bump k8s.io/apimachinery from 0.28.1 to 0.28.2 and k8s.io/client-go from 0.28.1 to 0.28.2 in /modules/k3s (#1683) chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.18.39 to 1.18.42 and github.com/aws/aws-sdk-go from 1.45.3 to 1.45.15 and github.com/aws/aws-sdk-go-v2/service/s3 from 1.38.5 to 1.39.0 in /modules/localstack (#1680) chore(deps): bump github.com/twmb/franz-go/pkg/kadm from 1.9.0 to 1.9.1 and github.com/twmb/franz-go from 1.14.4 to 1.15.0 in /modules/redpanda (#1682) chore(deps): bump cloud.google.com/go/datastore from 1.13.0 to 1.14.0 and google.golang.org/grpc from 1.58.1 to 1.58.2 and cloud.google.com/go/spanner from 1.47.0 to 1.49.0 in /modules/gcloud (#1681) feat: add GCloud module (#1670) make ryuk timeouts configurable via properties file (#1668) chore(deps): bump mkdocs-material from 8.2.7 to 9.3.2 (#1649) chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.58.1 and google.golang.org/api from 0.138.0 to 0.142.0 in /examples (#1667) feat: support for loading images in the K3s module (#1622)
….com/docker/compose/v2-2.22.0 * main: chore(deps): bump golang.org/x/text to v0.15.0 (#1687) chore(deps): bump github.com/shirou/gopsutil/v3 from 3.23.7 to 3.23.8 (#1651) Wait for k3s node to sync (#1685) chore(deps): bump github.com/IBM/sarama in /modules/kafka (#1637) chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (#1625) chore(deps): bump github.com/elastic/go-elasticsearch/v8 (#1641) chore(deps): bump github.com/tidwall/gjson from 1.16.0 to 1.17.0 in /modules/couchbase and /modules/vault (#1684) chore(deps): bump mkdocs from 1.5.2 to 1.5.3 (#1662) chore(deps): bump github.com/nats-io/nats.go in /modules/nats (#1657) chore(deps): bump k8s.io/apimachinery from 0.28.1 to 0.28.2 and k8s.io/client-go from 0.28.1 to 0.28.2 in /modules/k3s (#1683) chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.18.39 to 1.18.42 and github.com/aws/aws-sdk-go from 1.45.3 to 1.45.15 and github.com/aws/aws-sdk-go-v2/service/s3 from 1.38.5 to 1.39.0 in /modules/localstack (#1680) chore(deps): bump github.com/twmb/franz-go/pkg/kadm from 1.9.0 to 1.9.1 and github.com/twmb/franz-go from 1.14.4 to 1.15.0 in /modules/redpanda (#1682) chore(deps): bump cloud.google.com/go/datastore from 1.13.0 to 1.14.0 and google.golang.org/grpc from 1.58.1 to 1.58.2 and cloud.google.com/go/spanner from 1.47.0 to 1.49.0 in /modules/gcloud (#1681) feat: add GCloud module (#1670) make ryuk timeouts configurable via properties file (#1668) chore(deps): bump mkdocs-material from 8.2.7 to 9.3.2 (#1649) chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.58.1 and google.golang.org/api from 0.138.0 to 0.142.0 in /examples (#1667) feat: support for loading images in the K3s module (#1622)
What does this PR do?
Adds a function to k3s module for loading images into the k3s cluster.
It also adds helper functions for manipulating images to the docker provider, to facilitate testing.
Why is it important?
When testing images generated locally (for example, in a CI/CD workflow), it would be convenient not to have to push them to a repository in order to make them available to the k3s test container. Instead, the test should be able tp upload the images to the test container.
Related issues