Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for loading images in the K3s module #1622

Merged
merged 12 commits into from
Sep 21, 2023
Merged

feat: support for loading images in the K3s module #1622

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
565a142
Add image helpers
pablochacin Sep 17, 2023
5d76f6a
Add LoadImages function
pablochacin Sep 17, 2023
c073dd2
Document k3s LoadImages method
pablochacin Sep 18, 2023
aa2defb
Apply suggestions from code review
pablochacin Sep 19, 2023
13bb4c4
Fix filepath import
pablochacin Sep 19, 2023
f0791ac
Fix runnable example package
pablochacin Sep 19, 2023
669cbb1
Apply suggestions from code review
pablochacin Sep 19, 2023
2305e79
Fix linter isues
pablochacin Sep 19, 2023
e312712
Fix k3s import
pablochacin Sep 20, 2023
be65348
Simplify LoadImage API
pablochacin Sep 20, 2023
2b0ed21
Fix panin in test
pablochacin Sep 21, 2023
31f6a9a
Re-introduce LoadImages documentation
pablochacin Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/k3s/k3s_image_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,14 @@ func Test_LoadImages(t *testing.T) {
}

t.Run("Test load image not available", func(t *testing.T) {
err = k3sContainer.LoadImages(context.Background(), "nginx", "fake.registry/fake:non-existing")
err := k3sContainer.LoadImages(context.Background(), "fake.registry/fake:non-existing")
if err == nil {
t.Fatal("should had failed")
}
})

t.Run("Test load image in cluster", func(t *testing.T) {
err = k3sContainer.LoadImages(context.Background(), "nginx")
err := k3sContainer.LoadImages(context.Background(), "nginx")
if err != nil {
t.Fatal(err)
}
Expand Down Expand Up @@ -101,8 +101,8 @@ func Test_LoadImages(t *testing.T) {
if err != nil {
t.Fatal(err)
}

if pod.Status.ContainerStatuses[0].State.Waiting.Reason == "ErrImageNeverPull" {
waiting := pod.Status.ContainerStatuses[0].State.Waiting
if waiting != nil && waiting.Reason == "ErrImageNeverPull" {
mdelapenya marked this conversation as resolved.
Show resolved Hide resolved
t.Fatal("Image was not loaded")
}
})
Expand Down