Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker/docker package version #229

Merged

Conversation

snowhork
Copy link

@snowhork snowhork commented Jul 14, 2020

This PR is for updating docker/docker package in go.mod.

v0.7.3 is too old, so some secury check fails. (In our team, we use yamory (https://yamory.io/) (japanese))

@snowhork
Copy link
Author

please review @gianarb @alde @mraerino

@gianarb gianarb added the dependencies Dependencies or external services label Jul 20, 2020
@snowhork
Copy link
Author

any updates? @gianarb

@gianarb gianarb merged commit e013a9a into testcontainers:master Aug 19, 2020
@snowhork snowhork deleted the update-docker-library-version branch August 20, 2020 01:11
@kernle32dll
Copy link

kernle32dll commented Sep 17, 2020

Actually, this was a massive downgrade!

Take a closer look at the version number as it was: v0.7.3-0.20190506211059-b20a14b54661. The referenced version was actually commit hash b20a14b54661 (moby/moby@b20a14b54661), not 0.7.3.

The reason for this cryptic version number is the way go modules handle major versions. In short - docker should be importable via e.g. github.com/moby/moby/v19 - but its not

So - this PR actually downgraded to v1.13.1 (https://github.com/moby/moby/releases/tag/v1.13.1), which is a considerable downgrade.

TL;DR; - this should be reverted ASAP!

Side note: This indirectly causes #238

@alde alde mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants