Send optional platform spec when creating container

[hairyhenderson]

This is based on #342, and adds support for explicitly specifying image platform (like docker run --platform=...).

I'm opening a new PR because the other one seemed to be stalled, and I needed this for a project anyway. This differs slightly from #342:

• uses containerd's platforms.Parse to parse the platform string instead of strings.Split - this will also handle 3-part platform strings (such as linux/arm/v6)
• adds a positive test case (without actually starting the container, which is unnecessary)

Obviously having two PRs open for the same thing isn't ideal, and my goal isn't to compete with #342 - just to get things moving again. If @amitsaha wants to take some of these changes and rebase their own PR, I'm happy with this one being closed!

Signed-off-by: Dave Henderson dhenderson@gmail.com

[amitsaha]

I am happy for this PR to merged as well. If the maintainers want me to make the changes to my PR, i am happy to do that too.

[hairyhenderson]

Hey @mdelapenya @gianarb - sorry to bother you, could I get some eyes on this?

I've been using this commit successfully in some of my own tests for a few days with no issues so far.

[codecov]

Codecov Report

Merging #395 (9ec3ed4) into master (d303350) will increase coverage by 0.29%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   63.98%   64.27%   +0.29%     
==========================================
  Files          18       18              
  Lines        1108     1117       +9     
==========================================
+ Hits          709      718       +9     
  Misses        295      295              
  Partials      104      104              

Impacted Files	Coverage Δ
container.go	88.37% <ø> (ø)
docker.go	64.83% <83.33%> (+0.63%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d303350...9ec3ed4. Read the comment docs.

[mdelapenya]

LGTM, thanks for this contribution! and sorry for the delay in the review, I returned from Xmas PTO past Monday

[hairyhenderson]

@mdelapenya no worries, thanks for the review! Is there something I should to to fix the CI failure? It seems to be a linting issue with a file I didn't change... 🤔

[hairyhenderson]

@mdelapenya hi! any updates? should I do anything to fix the CI failure?

[mdelapenya]

@mdelapenya hi! any updates? should I do anything to fix the CI failure?

The CI is complaining about an EOF not properly set. Please take a look at #396

I'd say we better push the format fix in a separate PR so that your code can be rebased/merged on top of that

[hairyhenderson]

@mdelapenya I've issued #400 to fix the lint errors - please have a look - I'll rebase this once that one is merged

[gianarb]

Thanks a lot @hairyhenderson !!

[hairyhenderson]

Thanks @gianarb and @mdelapenya 🙇‍♂️