Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some lint errors #400

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

hairyhenderson
Copy link
Contributor

This fixes the errors that ./scripts/checks.sh gives me. Should unblock The CI failure that's blocking #395.

cc @mdelapenya

Signed-off-by: Dave Henderson dhenderson@gmail.com

Signed-off-by: Dave Henderson <dhenderson@gmail.com>
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #400 (cacaa87) into master (d303350) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   63.98%   64.16%   +0.18%     
==========================================
  Files          18       18              
  Lines        1108     1108              
==========================================
+ Hits          709      711       +2     
+ Misses        295      293       -2     
  Partials      104      104              
Impacted Files Coverage Δ
wait/errors.go 0.00% <ø> (ø)
docker.go 64.60% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d303350...cacaa87. Read the comment docs.

@mdelapenya mdelapenya merged commit 8b163de into testcontainers:master Feb 2, 2022
@hairyhenderson hairyhenderson deleted the fix-lint-errors branch February 2, 2022 14:14
@hairyhenderson
Copy link
Contributor Author

Thanks @mdelapenya! 🙇‍♂️

@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants