Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker java 3.1.4 #1631

Closed
wants to merge 3 commits into from

Conversation

pedro93
Copy link

@pedro93 pedro93 commented Jul 21, 2019

Bump to docker-java dependency to fix #1548

Replaces #1340 since I have no permissions to update that MR.

@bsideup
Copy link
Member

bsideup commented Jul 21, 2019

I am sorry that we have to bounce back with this one (again), but I see that the methods were added "one by one" instead of actually fixing the binary change.

To keep it clear what was actually changed, here is a link:
https://diff.revapi.org/?groupId=com.github.docker-java&artifactId=docker-java&old=3.1.0-rc-4&new=3.1.4

Just look for CreateContainerCmd:: (or Binary: BREAKING).

There are currently 38(!) binary breaking breaking changes between 3.1.0-rc-4 and 3.1.4 that we expect to be reverted, so that we can move forward with the upgrade.

@pedro93
Copy link
Author

pedro93 commented Jul 21, 2019

I am sorry that we have to bounce back with this one (again), but I see that the methods were added "one by one" instead of actually fixing the binary change.

That is a larger scope than what was originally said to me: #1340 (comment)

I do not have the context to perform those changes and know what the consequences would be.

Since I am not the maintainer of either repository nor have the insight to decide whether reverting the binary breaking changes is a good solution forward (reverting breaking changes would be contrary to the direction the docker-java repository is going by definition).

I shall then withdraw from trying to perform these changes.

Thank you for your time on this effort.

@pedro93 pedro93 closed this Jul 21, 2019
@bsideup
Copy link
Member

bsideup commented Jul 21, 2019

Hi @pedro93,

Thanks for the time you spent on it! I took over the effort and submitted docker-java/docker-java#1225

I'm in contact with Docker Java's maintainer and we hope that Testcontainers will receive the latest version of Docker Java very soon :)

@pedro93
Copy link
Author

pedro93 commented Jul 21, 2019

Looking forward to it, thank you @bsideup :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container Startup Failure due to UnrecognizedPropertyException in docker config file
2 participants