Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom exception message when HealthState not present in docker inspect response #2206

Merged
merged 1 commit into from Mar 26, 2020
Merged

Add custom exception message when HealthState not present in docker inspect response #2206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/src/main/java/org/testcontainers/containers/ContainerState.java
View file
Open in desktop
@@ -1,6 +1,7 @@
package org.testcontainers.containers;

import com.github.dockerjava.api.DockerClient;
import com.github.dockerjava.api.command.HealthState;
import com.github.dockerjava.api.command.InspectContainerResponse;
import com.github.dockerjava.api.exception.DockerException;
import com.github.dockerjava.api.model.ExposedPort;
Expand Down Expand Up @@ -89,9 +90,12 @@ default boolean isHealthy() {

try {
InspectContainerResponse inspectContainerResponse = getCurrentContainerInfo();
String healthStatus = inspectContainerResponse.getState().getHealth().getStatus();
HealthState health = inspectContainerResponse.getState().getHealth();
if (health == null) {
throw new RuntimeException("This container's image does not have a healthcheck declared, so health cannot be determined. Either amend the image or use another approach to determine whether containers are healthy.");
}

return healthStatus.equals(STATE_HEALTHY);
return STATE_HEALTHY.equals(health.getStatus());
} catch (DockerException e) {
return false;
}
Expand Down