Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable AWS KMS For LocalStack 0.10.8 #2812

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Enable AWS KMS For LocalStack 0.10.8 #2812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef1cab5
LocalStack version 0.10.8 supports AWS KMS.
May 28, 2020
4fa20bb
Added missing default ClientCredential
May 28, 2020
c30eafd
Merge branch 'master' into enable_aws_kms_for_localstack
SahilWadhwa Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ocalstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,8 @@ public enum Service {
STEPFUNCTIONS("stepfunctions", 4585),
CLOUDWATCHLOGS("logs", 4586),
STS("sts", 4592),
IAM("iam", 4593);
IAM("iam", 4593),
KMS("kms", 4599);

String localStackName;

Expand Down
26 changes: 22 additions & 4 deletions ...stack/src/test/java/org/testcontainers/containers/localstack/LocalstackContainerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
package org.testcontainers.containers.localstack;


import com.amazonaws.services.kms.AWSKMS;
import com.amazonaws.services.kms.AWSKMSClientBuilder;
import com.amazonaws.services.kms.model.CreateKeyRequest;
import com.amazonaws.services.kms.model.CreateKeyResult;
import com.amazonaws.services.kms.model.Tag;
import com.amazonaws.services.logs.AWSLogs;
import com.amazonaws.services.logs.AWSLogsClientBuilder;
import com.amazonaws.services.logs.model.CreateLogGroupRequest;
Expand Down Expand Up @@ -38,9 +43,7 @@
import static org.rnorth.visibleassertions.VisibleAssertions.assertEquals;
import static org.rnorth.visibleassertions.VisibleAssertions.assertThat;
import static org.rnorth.visibleassertions.VisibleAssertions.assertTrue;
import static org.testcontainers.containers.localstack.LocalStackContainer.Service.S3;
import static org.testcontainers.containers.localstack.LocalStackContainer.Service.SQS;
import static org.testcontainers.containers.localstack.LocalStackContainer.Service.CLOUDWATCHLOGS;
import static org.testcontainers.containers.localstack.LocalStackContainer.Service.*;

/**
* Tests for Localstack Container, used both in bridge network (exposed to host) and docker network modes.
Expand All @@ -58,7 +61,7 @@ public static class WithoutNetwork {
// without_network {
@ClassRule
public static LocalStackContainer localstack = new LocalStackContainer()
.withServices(S3, SQS, CLOUDWATCHLOGS);
.withServices(S3, SQS, CLOUDWATCHLOGS, KMS);
// }

@Test
Expand Down Expand Up @@ -135,6 +138,21 @@ public void cloudWatchLogsTestOverBridgeNetwork() {
assertEquals("One log group should be created", 1, groups.size());
assertEquals("Name of created log group is [foo]", "foo", groups.get(0).getLogGroupName());
}

@Test
public void kmsKeyCreationTest() {
AWSKMS awskms = AWSKMSClientBuilder.standard()
.withEndpointConfiguration(localstack.getEndpointConfiguration(KMS))
.withCredentials(localstack.getDefaultCredentialsProvider())
.build();

String desc = String.format("AWS CMK Description");
Tag createdByTag = new Tag().withTagKey("CreatedBy").withTagValue("StorageService");
CreateKeyRequest req = new CreateKeyRequest().withDescription(desc).withTags(createdByTag);
CreateKeyResult key = awskms.createKey(req);

assertEquals("AWS KMS Customer Managed Key should be created ", key.getKeyMetadata().getDescription(), desc);
}
}

public static class WithNetwork {
Expand Down