Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Docs for Webdriver Containers #2927

Merged

Conversation

raynigon
Copy link
Contributor

Convert inline example code to use codeinclude macro for the Webdriver Containers documentation.
See #1158 for more details.

Convert inline example code to use codeinclude macro for the Webdriver Containers documentation.
See #1158 for more details.
Convert inline example code to use codeinclude macro for the Webdriver Containers documentation.
See #1158 for more details.

Fixed ChromeRecordingWebDriverContainerTest which was crashed by previous commit.
Fix Labels for RECORD_ALL, RECORD_FAILING enum values.
@raynigon raynigon force-pushed the 1158_codeinclude_webdriver_containers branch from bf5bcbc to 0842999 Compare June 23, 2020 14:48
@raynigon
Copy link
Contributor Author

Difference in the docs, left (old) contains the inline code, right (new) was generated from the unit tests.
docs_diff

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome 😍
Thanks for taking this task on @raynigon!

@rnorth rnorth merged commit b0dbd31 into testcontainers:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants