Only publish exposed ports #4122

rnorth · 2021-05-24T15:43:37Z

…tes cause issues later

…hat non-exposed port is not bound

rnorth · 2021-05-25T07:01:56Z

core/src/main/java/org/testcontainers/containers/GenericContainer.java

@@ -1,8 +1,5 @@
 package org.testcontainers.containers;


Regarding imports, there are some changes in ordering, but AFAICT these only match the IntelliJ defaults (with our .editorconfig tweaks layered on top for star imports).

TBH I'd prefer to go with the changed (hopefully stable) import order in this PR, rather than continue to constantly have the burden of maintaining the order (I don't know why the current order is as it is).

I think if we find ourselves continuing to run up against this then we should introduce a code formatter to our build (e.g. spotless gradle plugin + google formatter with AOSP style (4 space indent)).

rnorth · 2021-05-25T07:03:22Z

core/src/main/java/org/testcontainers/containers/GenericContainer.java

+        // Next, ExposedPorts must be set up to publish all of the above ports, randomized and fixed.
+        // Collect all of the exposed ports for publication
+        final List<ExposedPort> exposedPorts = allPortBindings.stream()
+            .map(PortBinding::getExposedPort)
+            .distinct()
+            .collect(Collectors.toList());


This is the thing that is substantially different from the previous implementation; changes above are mainly to support this change and to make it clearer what we're doing.

Of course, createCommand.withPublishAllPorts(true); on line 801 is also nuked.

rnorth · 2021-05-25T07:04:58Z

modules/clickhouse/src/main/java/org/testcontainers/containers/ClickHouseContainer.java

@@ -54,8 +56,8 @@ public ClickHouseContainer(final DockerImageName dockerImageName) {
    }

    @Override
-    protected Integer getLivenessCheckPort() {
-        return getMappedPort(HTTP_PORT);
+    public Set<Integer> getLivenessCheckPortNumbers() {


Not strictly required for this PR, but during experimenting with approaches I found that a handful of our modules are using the getLivenessCheckPort method, which has been deprecated for 4 years. I'd like to take this chance to clean up.

modules/clickhouse/src/main/java/org/testcontainers/containers/ClickHouseContainer.java

rnorth · 2021-05-25T07:06:31Z

modules/couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseContainer.java

@@ -166,6 +166,19 @@ public String getConnectionString() {
    protected void configure() {
        super.configure();

+        addExposedPorts(


Interestingly the Couchbase module seems to have always relied on an EXPOSE statement + all-ports publication.

core/src/main/java/org/testcontainers/containers/GenericContainer.java

core/src/test/java/org/testcontainers/containers/GenericContainerTest.java

bsideup

💯

WIP

0e0e8c8

rnorth force-pushed the only-publish-exposed-ports branch from 0b15097 to 0e0e8c8 Compare May 24, 2021 16:25

rnorth added 6 commits May 24, 2021 17:27

Revert accidental change

cc133cd

Make exposed ports configuration distinct, in case accidental duplica…

c40be26

…tes cause issues later

Explicitly add exposed ports in CouchbaseContainer

1c0cded

Tidy and add comments

1373b0e

Merge branch 'master' into only-publish-exposed-ports

006533e

Change port binding assertion to work cross-platform, and add check t…

c0dcddc

…hat non-exposed port is not bound

rnorth commented May 25, 2021

View reviewed changes