Refactor JDBC URL parsing to support different Oracle URLs #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…honor this in the underlying JDBC URL. - Switched affected regex patterns to use named groups - Add tests for both SID and service name connections
Tags containing any of the chars [t,h,i,n] would break
|
japicmp is faling on CI, but I don't see the change that leads to this. Can't check right now locally, because japicmp does not run on our Windows build. |
kiview
reviewed
Sep 22, 2021
|
Ergh; I'll fix - I removed an unused constant without realising that it's public 😞. |
kiview
approved these changes
Sep 22, 2021
kiview
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit belongs mainly to @justinwyer. Split out from #4382
:or service name/in the supplied TC jdbc URL and honor this in the underlying JDBC URL.