Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor JDBC URL parsing to support different Oracle URLs #4476

Merged
merged 5 commits into from
Sep 23, 2021
Merged

Refactor JDBC URL parsing to support different Oracle URLs #4476

merged 5 commits into from
Sep 23, 2021

Commits on Sep 22, 2021

  1. - Detect SID : or service name / in the supplied TC jdbc URL and … 

    …honor this in the underlying JDBC URL.

 - Switched affected regex patterns to use named groups
 - Add tests for both SID and service name connections
    @rnorth
    Justin Wyer authored and rnorth committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    51eb24b View commit details
    Browse the repository at this point in the history

  2. Further tidying

    @rnorth
    rnorth committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    b971a1e View commit details
    Browse the repository at this point in the history

  3. Further tidying

    @rnorth
    rnorth committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    3fbd7fa View commit details
    Browse the repository at this point in the history

  4. Fix image tag extraction 

    Tags containing any of the chars [t,h,i,n] would break
    @rnorth
    rnorth committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    d3bc44c View commit details
    Browse the repository at this point in the history

  5. Reinstate and deprecate unused constant

    @rnorth
    rnorth committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    97f627a View commit details
    Browse the repository at this point in the history