Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish code samples so that they are easier to copy & paste #5038

Merged

Conversation

maciejwalkowiak
Copy link
Contributor

No description provided.

@JurrianFahner
Copy link
Contributor

@maciejwalkowiak It really depends how you have added your logger. In your code. For example if you would use lombok, you would use log.

If you add it by hand, LOGGER would make more sense.

See: https://projectlombok.org/features/log

@maciejwalkowiak
Copy link
Contributor Author

@JurrianFahner indeed, I am not arguing about better name for logger field. LOGGER is just consistent with what is described above https://github.com/testcontainers/testcontainers-java/pull/5038/files#diff-771749e9c2131e4371d45e53427dee76d3a9aca99a9d2c29ddd28a0cf9f9049dR33

Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, you are right @maciejwalkowiak, thanks for pointing out this inconsistency.

@kiview kiview added this to the next milestone Feb 17, 2022
@kiview kiview merged commit 71a073b into testcontainers:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants