-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply spotless and checkstyle #5390
Conversation
eddumelendez
commented
May 20, 2022
- Apply spotless and checkstyle
- Add preCommit
} | ||
|
||
dependencies { | ||
// https://github.com/melix/japicmp-gradle-plugin/issues/36 | ||
classpath 'com.google.guava:guava:30.1.1-jre' | ||
classpath 'com.github.kiview:captain-hook:76a1c11a16' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kiview do you remember why we had to fork it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to make it work with windows I guess https://github.com/kiview/captain-hook/commits/master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, PR was never merged in upstream, since upstream seems to be dead 😞
tjni/captain-hook#4
This reverts commit 171bba2.
modules/db2/src/main/java/org/testcontainers/containers/Db2Container.java
Outdated
Show resolved
Hide resolved
...elasticsearch/src/test/java/org/testcontainers/elasticsearch/ElasticsearchContainerTest.java
Outdated
Show resolved
Hide resolved
the |
core/src/main/java/org/testcontainers/containers/output/OutputFrame.java
Outdated
Show resolved
Hide resolved
@Language("groovy") | ||
String myTest = """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those lines should be aligned. But if it is hard to configure, we can live with that.
core/src/test/java/org/testcontainers/junit/DockerfileContainerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/testcontainers/junit/ParameterizedDockerfileContainerTest.java
Outdated
Show resolved
Hide resolved
docs/examples/junit4/generic/src/test/java/generic/WaitStrategiesTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 💯