Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgis #24

Closed
ekeraghossian opened this issue Jul 16, 2023 · 3 comments · Fixed by #32
Closed

Postgis #24

ekeraghossian opened this issue Jul 16, 2023 · 3 comments · Fixed by #32

Comments

@ekeraghossian
Copy link

ekeraghossian commented Jul 16, 2023 •
edited
Loading

Hi,
I need to use this plugin with a postgis database, is there any easy way to achieve that since it is a flavour of postgres?

I made some changes to include postgis in the database type and create a container. But it is failing to pull the postgis image from the container that runs testcontainers.

Regards,
Eskandar
@romchellis
Copy link
Contributor

Hi @ekeraghossian , could you create a pull request for MWE? I would see and try to help

zzzLobster added a commit to zzzLobster/testcontainers-jooq-codegen-maven-plugin that referenced this issue Oct 3, 2023
@zzzLobster
testcontainers#24 Support custom Docker images for Postgres (i.e. Pos…
0abf0a1 
…tgis)
@zzzLobster zzzLobster mentioned this issue Oct 3, 2023
Merged
@zzzLobster
Copy link
Contributor

zzzLobster commented Oct 3, 2023 •
edited
Loading

Hi @romchellis , I have created a PR for this issue (#32).
I thought about making it more strict, like to enable Postgis specifically, but finally decided that it is also good to have ability to use any custom image.

@romchellis
Copy link
Contributor

hi @zzzLobster ,seems ok

eddumelendez added a commit that referenced this issue Oct 6, 2023
@zzzLobster @eddumelendez
#24 Support custom Docker images for Postgres (i.e. Postgis) (#32)
d74e2f0 
Fixes #24

---------

Co-authored-by: Eddú Meléndez <eddu.melendez@gmail.com>
@rajadilipkolli rajadilipkolli mentioned this issue Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zzzLobster @ekeraghossian @romchellis