Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#24 Support custom Docker images for Postgres (i.e. Postgis) #32

Merged
merged 5 commits into from
Oct 6, 2023
Merged

#24 Support custom Docker images for Postgres (i.e. Postgis) #32

merged 5 commits into from
Oct 6, 2023

Conversation

zzzLobster
Copy link
Contributor

@zzzLobster zzzLobster commented Oct 3, 2023 •
edited
Loading

This is to fix #24 and support custom Docker images for Postgres

@zzzLobster zzzLobster requested a review from a team as a code owner October 3, 2023 12:20
@zzzLobster zzzLobster mentioned this pull request Oct 3, 2023
Closed
romchellis
romchellis reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@romchellis romchellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, generally i'm good with changes

pom.xml Outdated Show resolved Hide resolved
src/main/java/org/testcontainers/jooq/codegen/database/DatabaseProvider.java Outdated Show resolved Hide resolved
src/test/resources/pom/postgis-flyway/pom.xml Outdated Show resolved Hide resolved
romchellis
romchellis approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@romchellis romchellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rajadilipkolli
Copy link
Contributor

This is to fix #24 and support custom Docker images for Postgres

+1 for the fix to be included

@eddumelendez eddumelendez added the enhancement New feature or request label Oct 6, 2023
@eddumelendez eddumelendez added this to the next milestone Oct 6, 2023
@eddumelendez eddumelendez merged commit d74e2f0 into testcontainers:main Oct 6, 2023
1 check passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @zzzLobster!

@zzzLobster zzzLobster deleted the bugfix/24 branch October 7, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaprasadreddy sivaprasadreddy sivaprasadreddy approved these changes

@eddumelendez eddumelendez eddumelendez approved these changes

@romchellis romchellis romchellis approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Postgis
5 participants
@zzzLobster @rajadilipkolli @eddumelendez @sivaprasadreddy @romchellis