Jooq into separate tag #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romchellis
force-pushed
the
feature/move-jooq-to-separate-tag
branch
from
11e86df
to
0229318
Compare
pom.xml
Outdated
| @@ -62,7 +67,7 @@ | |||
| <mysql-connector-j.version>8.0.32</mysql-connector-j.version> | |||
| <mariadb-java-client.version>3.1.2</mariadb-java-client.version> | |||
| <assertj-core.version>3.24.2</assertj-core.version> | |||
| <maven-plugin-testing-harness.version>3.3.0</maven-plugin-testing-harness.version> | |||
| <maven-plugin-testing-harness.version>4.0.0-alpha-1</maven-plugin-testing-harness.version> | |||
There was a problem hiding this comment.
Any reason for using Alpha version considering alpha releases might be buggy?
There was a problem hiding this comment.
No, actually i will return
| } | ||
| public class PluginTest { | ||
|
|
||
| @Rule |
There was a problem hiding this comment.
Is it not possible to use JUnit 5 here? Once we introduce the dependency on JUnit 4 it will be hard to remove later.
There was a problem hiding this comment.
Actually AbstractMojoTestCase extends TestCase from Junit3 .
Usage of @Rule make possible to use Junit4 out of the box. I agree that v5 better than v4, but generally there is no difference ,because we have junit-vintage-engine which gets us backward compatibility.
I'd love to pick Junit5 ,but maven-plugin-testing-harness does not support it :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sivaprasadreddy , @lukaseder .
I did suggested approach, may i get your review?
Resolves #12