Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tests into different components for easier debugging. #212

Merged
merged 8 commits into from
May 7, 2022

Conversation

tillahoffmann
Copy link
Collaborator

@tillahoffmann tillahoffmann commented May 5, 2022

This PR sets up different test runs for different components to simplify inspection of test failures. Only the core tests will be required to pass for pull requests. Ideally, all tests will pass, but, in light of a variety of containers being added to the project, maintaining all of them has become a substantial commitment. The change should also speed up the pipeline because tests are run in parallel. It also adds more recent python versions to the test matrix.

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #212 (a9be3f2) into master (4fba477) will decrease coverage by 22.38%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #212       +/-   ##
===========================================
- Coverage   85.67%   63.28%   -22.39%     
===========================================
  Files          25       25               
  Lines         670      670               
  Branches       60       64        +4     
===========================================
- Hits          574      424      -150     
- Misses         76      230      +154     
+ Partials       20       16        -4     
Impacted Files Coverage Δ
testcontainers/core/generic.py 77.14% <100.00%> (-8.58%) ⬇️
testcontainers/mssql.py 0.00% <0.00%> (-100.00%) ⬇️
testcontainers/postgres.py 0.00% <0.00%> (-100.00%) ⬇️
testcontainers/google/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
testcontainers/compose.py 0.00% <0.00%> (-98.37%) ⬇️
testcontainers/google/pubsub.py 0.00% <0.00%> (-95.46%) ⬇️
testcontainers/mysql.py 0.00% <0.00%> (-84.00%) ⬇️
testcontainers/oracle.py 0.00% <0.00%> (-55.56%) ⬇️
testcontainers/core/container.py 70.21% <0.00%> (-7.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98398ff...a9be3f2. Read the comment docs.

@tillahoffmann tillahoffmann marked this pull request as ready for review May 6, 2022 15:01
@tillahoffmann tillahoffmann requested a review from yakimka May 6, 2022 15:01
Copy link
Collaborator

@yakimka yakimka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@tillahoffmann tillahoffmann merged commit 59ba1c5 into testcontainers:master May 7, 2022
@tillahoffmann tillahoffmann deleted the separation branch May 7, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants