Add new postgresql env vars (#1) #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for additional PostgreSQL Container env variables. Added interface for environment variables that the PostgreSQL container now supports: * POSTGRES_INITDB_ARGS * POSTGRES_INITDB_WALDIR * POSTGRES_HOST_AUTH_METHOD * PGDATA As a bonus, added tests for POSTGRES_INITDB_ARGS and POSTGRES_HOST_AUTH_METHOD.
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 86.73% 86.87% +0.14%
==========================================
Files 29 29
Lines 814 823 +9
Branches 57 59 +2
==========================================
+ Hits 706 715 +9
Misses 78 78
Partials 30 30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hmm, is testcontaners-python an abandoned project? |
|
Hey, sorry for the delay. I'll revisit this PR once #296 is merged. |
|
#296 has been merged. Would you mind rebasing on |
|
Uh. Not sure why the PR above changed. I renamed master to main in my Fork to match the upstream here about the time this says I deleted the master branch. From the look of #296, it looks like I'll have substantial refactoring to make to match current main, so maybe not a bad thing if I start with a fresh post-296 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added interface for environment variables that the PostgreSQL container now supports:
As a bonus, added tests for POSTGRES_INITDB_ARGS and POSTGRES_HOST_AUTH_METHOD.
Issue #278