Remove class-level variables from containers. #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillahoffmann
force-pushed
the
pythonic
branch
from
915b67f
to
b9b4b2c
Compare
7 tasks
This was referenced Feb 17, 2023
tillahoffmann
force-pushed
the
pythonic
branch
from
0735f3d
to
3add8cb
Compare
tillahoffmann
requested review from
maltehedderich and
ImFlog
as code owners
tillahoffmann
requested review from
timbmg,
ash1425,
yakimka and
pffijt
as code owners
tillahoffmann
force-pushed
the
pythonic
branch
from
494ff33
to
76a9bfa
Compare
pffijt
reviewed
Feb 23, 2023
pffijt
approved these changes
Feb 23, 2023
|
We should fix the minor inconsistencies then this pr should be ready for merge. |
ImFlog
approved these changes
Feb 23, 2023
pffijt
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of the containers currently load environment variables at import time. Consequently, if we create a container, its configuration may not match the current environment variables. Containers also overwrite class variables with instance variables of the same name which can cause confusion.
This PR
usertousernameandport_to_exposetoportwhere applicable such that all containers have the same parameter names. The motivation behind renamingport_to_exposeis that some containers have multiple different ports (cf. Clickhouse container exposing ports setup is strange #257 and Add azurite module #234).[specific]_port_to_exposeis just a bit long.This will break a bunch of stuff, but I'm planning to squeeze a lot of this cleanup into the next major release.