feat(core)!: add support for tc.host and de-prioritise docker:dind
#388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiview
commented
Oct 20, 2023
| return self.get_docker_client().bridge_ip(self._container.id) | ||
| return gateway_ip | ||
| # # check testcontainers itself runs inside docker container | ||
| # if inside_container() and not os.getenv("DOCKER_HOST") and not host.startswith("http://"): |
There was a problem hiding this comment.
Had to do it, to get things working with Testcontainers Cloud within Codespaces (which runs inside a container). I also thought part of this code duplicate what is done in docker_client.py.
totallyzen
changed the title
totallyzen
changed the title
tc.host to support Testcontainers Desktop
totallyzen
changed the title
tc.host to support Testcontainers Desktoptc.host and de-prioritise docker:dind
totallyzen
approved these changes
Mar 1, 2024
Comment on lines
-26
to
-34
|
|
||
|
|
||
| def _stop_container(container: Container) -> None: | ||
| try: | ||
| container.stop() | ||
| except NotFound: | ||
| pass | ||
| except Exception as ex: | ||
| LOGGER.warning("failed to shut down container %s with image %s: %s", container.id, container.image, ex) |
There was a problem hiding this comment.
private function -> moved to the bottom of this file
totallyzen
pushed a commit
that referenced
this pull request
Mar 6, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.0](testcontainers-v3.7.1...testcontainers-v4.0.0) (2024-03-06) ### Release Notes The breaking changes are the ones we were able to easily track. If you spot any new issues between `3.7.1` and `4.0.0`, please do report it and we'll do our best to fix everything. The release is now Some kudos from @totallyzen to folks who helped a great deal in starting things again: - kudos to @alexanderankin for his contribution on #426 - kudos to @jankatins for feedback on various PRs including - kudos to @max-pfeiffer and @bearrito for their contributions as well ### ⚠ BREAKING CHANGES * **compose:** implement compose v2 with improved typing ([#426](#426)) * **core:** add support for `tc.host` and de-prioritise `docker:dind` ([#388](#388)) ### Features * **build:** use poetry and organise modules ([#408](#408)) ([6c69583](6c69583)) * **compose:** allow running specific services in compose ([f61dcda](f61dcda)) * **compose:** implement compose v2 with improved typing ([#426](#426)) ([5356caf](5356caf)) * **core:** add support for `tc.host` and de-prioritise `docker:dind` ([#388](#388)) ([2db8e6d](2db8e6d)) * **redis:** support AsyncRedisContainer ([#442](#442)) ([cc4cb37](cc4cb37)) * **release:** automate release via release-please ([#429](#429)) ([30f859e](30f859e)) ### Bug Fixes * Added URLError to exceptions to wait for in elasticsearch ([0f9ad24](0f9ad24)) * **build:** add `pre-commit` as a dev dependency to simplify local dev and CI ([#438](#438)) ([1223583](1223583)) * **build:** early exit strategy for modules ([#437](#437)) ([7358b49](7358b49)) * changed files breaks on main ([#422](#422)) ([3271357](3271357)) * flaky garbage collection resulting in testing errors ([#423](#423)) ([b535ea2](b535ea2)) * rabbitmq readiness probe ([#375](#375)) ([71cb75b](71cb75b)) * **release:** prove that the release process updates the version ([#444](#444)) ([87b5873](87b5873)) * test linting issue ([427c9b8](427c9b8)) ### Documentation * Sphinx - Add title to each doc page ([#443](#443)) ([750e12a](750e12a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for reading the
tc.hostproperty from the~/.testcontainers.propertiesfile. This config will have the highest priority for configuring the Docker client.Why is it important
This brings Testcontainers Desktop support to testcontainers-python and aligns this language with the
TestcontainersHostStrategyfound it testcontainers-java.Misc
I wasn't able to get a working testcontainers-python development environment set up on my M2 MacBook. This seems to be related to some kind of Cython 3.0.0 issue, that I don't fully understand and trying to fix it breaks the installation of further dependencies (like pymssql). So I was only able to test it in an Ubuntu Codespaces environment (also required some weird Cython workarounds).
Breaking Changes
tc.hostthis PR prioritised having that over truedocker:dinduse casesdocker:dindcontainer-v /var/run/docker.sock:/var/run/docker.sockyou should be unaffected since your containers run on the original host