-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No container teardown for isolated test #106
Comments
200: Fix `Cli::rm` not blocking until rm is successful r=thomaseizinger a=TheButlah Fixes #199 Potentially fixes - #193, #106 Changed: - `Cli::rm()` method now blocks until command finishes executing. Added: - Test case to ensure that `Cli::rm()` command actually fails instead of silently succeeding. Co-authored-by: Ryan Butler <thebutlah@gmail.com>
200: Fix `Cli::rm` not blocking until rm is successful r=thomaseizinger a=TheButlah Fixes #199 Potentially fixes - #193, #106 Changed: - `Cli::rm()` method now blocks until command finishes executing. Added: - Test case to ensure that `Cli::rm()` command actually fails instead of silently succeeding. Co-authored-by: Ryan Butler <thebutlah@gmail.com>
Any chance you can try to reproduce the issue with latest |
The original issue was about containers staying up when running tests independently, but I just ran |
Actually, I think the reason this happened was unrelated to |
The expectation is that
testcontainers
should tear down a container after a test is completed, but when running the following test in isolation usingcargo test <TESTNAME>
the docker container remains up after the test has passed.
Interestingly, this doesn't happen if the test is run using
cargo test
.The text was updated successfully, but these errors were encountered: