Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: support wait_times for log wait strategy. #675

Closed
DDtKey opened this issue Jul 3, 2024 · 0 comments · Fixed by #683
Closed

Feature request: support wait_times for log wait strategy. #675

DDtKey opened this issue Jul 3, 2024 · 0 comments · Fixed by #683
Assignees
@DDtKey
Labels
enhancement New feature or request
Milestone
0.20.0

Comments

@DDtKey
Copy link
Collaborator

DDtKey commented Jul 3, 2024 •
edited
Loading

We need this feature to cover more possible scenarios of waiting.
It should be close to semantic of testcontainers in other languages, like in Java: LogMessageWaitStrategy withTimes

Initially comes from testcontainers/testcontainers-rs-modules-community#158
@DDtKey DDtKey added the enhancement New feature or request label Jul 3, 2024
@DDtKey DDtKey added this to the 0.20.0 milestone Jul 3, 2024
@DDtKey DDtKey self-assigned this Jul 3, 2024
DDtKey added a commit that referenced this issue Jul 6, 2024
@DDtKey
feat(wait)!: enhance LogWaitStrategy to wait for message appearance…
35e611f 
… multiple times

The interface has been changed a bit to support advanced configuration of the strategy. For example, to expect a message to appear twice in `stdout`:

```rs
WaitFor::log(
    LogWaitStrategy::stdout("server is ready")
    .with_times(2),
)
```

Closes #675
@DDtKey DDtKey mentioned this issue Jul 6, 2024
Merged
@DDtKey DDtKey closed this as completed in b7c5bbf Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DDtKey DDtKey

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.20.0
1 participant
@DDtKey