fix!: update ports on container restart #562
Conversation
DDtKey
changed the title
| @@ -222,8 +222,9 @@ where | |||
| self.docker_client.stop(&self.id) | |||
| } | |||
|
|
|||
| pub fn start(&self) { | |||
| pub fn start(&mut self) { | |||
There was a problem hiding this comment.
It's definitely breaking change fix, because public interface has been changed.
In order to avoid this we could consider interior mutability for ports instead.
However, it might be not really safe to introduce interior mutability here.
Because another usage of the container might need to be aware of the restart and port changes, thus mut reference provides some guarantees to us regarding API.
There was a problem hiding this comment.
As this crate hasn't reached 1.0 yet maybe we should just do the breaking change and wait for the next release (0.16.0) to publish it.
There was a problem hiding this comment.
Yes, general interface is gonna be refactored anyway with breaking changes.
So I'm ok with that
DDtKey
changed the title
DDtKey
changed the title
|
Actually it looks like we just don't need to cache the ports, see #392 (comment) I'm going to refactor this as part of new version (which addresses #563 and #386). Thank you very much for the contribution 🙏 |
fix #561