Project revamp #563
Assignees
Labels
enhancement
New feature or request
Comments
This was referenced Apr 6, 2024
This was referenced Apr 16, 2024
DDtKey
added a commit
that referenced
this issue
Apr 18, 2024
Quite large refactoring as part of project revamp #563, and also the long-awaited refactoring #386 Closes #386 Closes #326 Closes #475 Closes #508 Closes #392 Closes #561 Closes #559 MSRV was bumped to `1.70` in order to use `std::sync::OnceLock`. This should NOT be a problem, tests usually executed on more recent versions (also see [this ref](https://github.com/testcontainers/testcontainers-rs/pull/503/files#r1242651354)).
DDtKey
added a commit
that referenced
this issue
Apr 18, 2024
Quite large refactoring as part of project revamp #563, and also the long-awaited refactoring #386 Closes #386 Closes #326 Closes #475 Closes #508 Closes #392 Closes #561 Closes #559 MSRV was bumped to `1.70` in order to use `std::sync::OnceLock`. This should NOT be a problem, tests usually executed on more recent versions (also see [this ref](https://github.com/testcontainers/testcontainers-rs/pull/503/files#r1242651354)).
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 22, 2024
Quite large refactoring as part of project revamp #563, and also the long-awaited refactoring #386 Now it's really simple API, e.g: ```rs let container = GenericImage::new("redis", "latest") .with_exposed_port(6379) .with_wait_for(WaitFor::message_on_stdout("Ready to accept connections")) .start(); ``` I find this new API much easier to use, solves a lot of problems, and seems flexible enough to be extended. This also works regardless of the tokio runtime flavor (multi-thread vs current-thread). And the sync API is still available, right under `blocking` feature (just like `reqwest` does). From a maintainer's perspective this also simplifies the code, we don't have to worry about two different clients and their differences. ### Docker host resolution The host is resolved in the following order: 1. Docker host from the `tc.host` property in the `~/.testcontainers.properties` file. 2. `DOCKER_HOST` environment variable. 3. Docker host from the "docker.host" property in the `~/.testcontainers.properties` file. 4. Else, the default Docker socket will be returned. ### Notes - MSRV was bumped to `1.70` in order to use `std::sync::OnceLock`. This should NOT be a problem, tests usually executed on more recent versions (also see [this ref](https://github.com/testcontainers/testcontainers-rs/pull/503/files#r1242651354)). - `Cli` client is removed, instead we provide `sync` (under `blocking` feature) and `async` impls based on HTTP client (bollard) - tested with [modules](https://github.com/testcontainers/testcontainers-rs-modules-community) ## Migration guide - Sync API migration (`Cli` client) - Add `blocking` feature - Drop all usages of `clients::Cli` - Add `use testcontainers::runners::SyncRunner;` - Replace `client.run(image)` with `image.start()` - Async API migration (`Http` client) - Remove `experimental` feature - Drop all usages of `clients::Http` - Add `use testcontainers::runners::AsyncRunner;` - Replace `client.run(image)` with `image.start()` ## References Closes #386 Closes #326 Closes #475 Closes #508 Closes #392 Closes #561 Closes #559 Closes #564 Closes #538 Closes #507 Closes #89 Closes #198
|
I've extracted separate issues for remaining tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
clisupporttc.hostfrom~/.testcontainers.propertiesto connect with http client. See issue related to the docker clienttc-rust/<version>, version should be the version from Cargo.tomlTasks
tc-rust/<version>#576testcontainers/ryukas resource reaper #577The text was updated successfully, but these errors were encountered: