Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DockerComposeContainer.Def #100

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Added DockerComposeContainer.Def #100

merged 1 commit into from
Jan 12, 2020

Conversation

LMnet
Copy link
Contributor

@LMnet LMnet commented Jan 12, 2020

Fix for #97

@LMnet LMnet mentioned this pull request Jan 12, 2020
Closed
@dimafeng
Copy link
Collaborator

Something is failing

[error] /home/travis/build/testcontainers/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/DockerComposeContainer.scala:91:7: illegal start of simple expression

[error]       )

[error]       ^

[error] /home/travis/build/testcontainers/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/DockerComposeContainer.scala:92:5: ')' expected but '}' found.

[error]     }

[error]     ^

[error] two errors found

@LMnet
Copy link
Contributor Author

LMnet commented Jan 12, 2020

It was a trailing comma. I forgot about 2.11 cross-compilation.

@dimafeng dimafeng merged commit 2714fc9 into testcontainers:master Jan 12, 2020
kittsville added a commit to kittsville/testcontainers-scala that referenced this pull request Dec 23, 2020
@kittsville
Document DockerComposeContainer usage
920311c 
Add an example of defining and starting a container, from a docker-compose file, using the new API (testcontainers#78, support added testcontainers#100)
@kittsville kittsville mentioned this pull request Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LMnet @dimafeng