Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Switch to eslint #335

Closed
silkentrance opened this issue Nov 10, 2022 · 0 comments · Fixed by #348
Closed

[INTERNAL] Switch to eslint #335

silkentrance opened this issue Nov 10, 2022 · 0 comments · Fixed by #348
Assignees
@silkentrance
Labels
internal Some internal task/chore
Milestone
v0.3.3

Comments

@silkentrance
Copy link
Member

silkentrance commented Nov 10, 2022 •
edited

tslint was depecrated.

  • we will use a rather lax set of rules so that eslint will not fail
  • with the current code base and non-lax eslint rules, all builds will be failing until [FEATURE] New API #315 is in place
    rewriting parts of the code base until that is not an option.

see also #312
@silkentrance silkentrance added the internal Some internal task/chore label Nov 10, 2022
This was referenced Nov 10, 2022
Closed
Closed
silkentrance added a commit that referenced this issue Nov 11, 2022
@silkentrance
Switch to eslint
b1572cb 
fix #335
@silkentrance silkentrance linked a pull request Nov 11, 2022 that will close this issue
[INTERNAL] Switch to eslint #348
Merged
@silkentrance silkentrance mentioned this issue Nov 11, 2022
Merged
@silkentrance silkentrance self-assigned this Nov 11, 2022
silkentrance added a commit that referenced this issue Nov 11, 2022
@silkentrance
Switch to eslint
03c6db5 
fix #335
@silkentrance silkentrance added this to the v0.3.3 milestone Dec 5, 2022
@silkentrance silkentrance mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silkentrance silkentrance

Labels
internal Some internal task/chore
Projects
None yet
Milestone
v0.3.3
Development

Successfully merging a pull request may close this issue.

[INTERNAL] Switch to eslint testdeck/testdeck
1 participant
@silkentrance