Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use eslint instead of tslint #312

Closed
wants to merge 5 commits into from
Closed

use eslint instead of tslint #312

wants to merge 5 commits into from

Conversation

silkentrance
Copy link
Member

No description provided.

@silkentrance silkentrance linked an issue Sep 24, 2022 that may be closed by this pull request
tslint was deprecated in favour of eslint #308
Closed
@silkentrance silkentrance added the internal Some internal task/chore label Sep 24, 2022
pana-cc
pana-cc previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@pana-cc pana-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint sounds good, there are some lint errors about single vs doble quotes...

@silkentrance silkentrance force-pushed the 308-tslint-was-deprecated-in-favour-of-eslint branch 3 times, most recently from 65fbd47 to c8653f9 Compare September 26, 2022 14:23
@silkentrance silkentrance marked this pull request as draft September 26, 2022 14:24
@silkentrance
Copy link
Member Author

@pana-cc Yes, the single vs. double quote issue has already been solved. However, we have a lot of complaints about accessing undefined properties on any and so on. Also, there are complaints about unbound functions and using Function as a type.

Besides of that, there are also multiple complaints about indentation.

I will try to address these while migrating each package to eslint.

@silkentrance silkentrance force-pushed the 308-tslint-was-deprecated-in-favour-of-eslint branch from c8653f9 to 736857f Compare September 29, 2022 14:33
This was referenced Oct 6, 2022
Merged
Closed
Closed
@silkentrance
Copy link
Member Author

Closing in favor of #315(#316)

@silkentrance silkentrance deleted the 308-tslint-was-deprecated-in-favour-of-eslint branch October 28, 2022 13:58
@silkentrance silkentrance mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pana-cc pana-cc pana-cc left review comments

Assignees
No one assigned
Labels
internal Some internal task/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tslint was deprecated in favour of eslint
2 participants
@silkentrance @pana-cc