Support deep matchers #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tdouble.js into uhoh-itsmaciek-deep-matchers
Finally looked at implementation and saw that it'd recurse infinitely for objects with circular structures, which is definitely not good (and will break td.js even when not using matchers
Trying to implement a recursive element comparator entirely inside this function would have been really confusing/error prone (esp. considering how much work has gone into making lodash's do the right thing). This commit uses the `_.isEqualWith` function's `customizer` predicate to be able to selectively compare values that match a condition (or return undefined to fall back to default behavior. In our case, if the expected element is a matcher (which we can determine based on the presence of `__matches`), then we will try to match it to the actual element. This fixes e4ea059
There's no apparent test for this.
|
Figured out the reason for the breaking build is that when stringify-object dropped Node < 4 support, our browserify build will now contain a bunch of unsupported-in-some-browsers-like-phantomjs keywords like I'm unsure how to tell Reference: |
(But alas, tethering on 2G data does not agree with `npm`)
This was referenced Mar 12, 2017
Closed
|
omg thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #142, #109, #160