New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deep matchers #203
Merged
Merged
Commits on Mar 10, 2017
-
Merge branch 'deep-matchers' of https://github.com/uhoh-itsmaciek/tes…
…tdouble.js into uhoh-itsmaciek-deep-matchers
Configuration menu - View commit details
-
Copy full SHA for 9ef33df - Browse repository at this point
Copy the full SHA 9ef33dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a5b608 - Browse repository at this point
Copy the full SHA 3a5b608View commit details
Commits on Mar 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 617ca8e - Browse repository at this point
Copy the full SHA 617ca8eView commit details -
Test to expose circular structure bug in impl
Finally looked at implementation and saw that it'd recurse infinitely for objects with circular structures, which is definitely not good (and will break td.js even when not using matchers
Configuration menu - View commit details
-
Copy full SHA for e4ea059 - Browse repository at this point
Copy the full SHA e4ea059View commit details -
Eliminate custom comparison logic
Trying to implement a recursive element comparator entirely inside this function would have been really confusing/error prone (esp. considering how much work has gone into making lodash's do the right thing). This commit uses the `_.isEqualWith` function's `customizer` predicate to be able to selectively compare values that match a condition (or return undefined to fall back to default behavior. In our case, if the expected element is a matcher (which we can determine based on the presence of `__matches`), then we will try to match it to the actual element. This fixes e4ea059
Configuration menu - View commit details
-
Copy full SHA for ed26ac4 - Browse repository at this point
Copy the full SHA ed26ac4View commit details
Commits on Mar 12, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 19d1cf7 - Browse repository at this point
Copy the full SHA 19d1cf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c733ba0 - Browse repository at this point
Copy the full SHA c733ba0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fabb7b - Browse repository at this point
Copy the full SHA 0fabb7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2256ad3 - Browse repository at this point
Copy the full SHA 2256ad3View commit details -
this will start working as soon as I publish
(But alas, tethering on 2G data does not agree with `npm`)
Configuration menu - View commit details
-
Copy full SHA for ebc091a - Browse repository at this point
Copy the full SHA ebc091aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.