Implement callback stubbing APIs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test structure has made no sense since we introduced browserify. At this point, the more honest thing is to admit the test suite is all integration and will only exercise the lib through the top-level object. Some tests will need to be Node.js only, like `test/lib/testdouble-test.js`, which makes zero sense when invoked against the browserified bundle. Remove the interactive testem config, since it didn't work to begin with.
I couldn't settle on a universally best way to stub callback arguments, so I implemented several options. The only option I didn't include was the one I personally wanted most: ``` td.when(myTd(td.callback(123))) ``` Because I didn't want to cook up some sneaky way of figuring out whether or not the `td.when.thenX` was going to be invoked or not. I imagine in simple cases, an implied last-arg callback plus thenCallback will be preferable, but in complex cases (say, where both a callback and the return value matter), then the td.callback(args...) matcher + thenReturn will allow more complete stubbings I still need to noodle on how this might be used to simplify multi-step callback verifications, but the stubbing alone may be enough to cover those cases
searls
added a commit
that referenced
this pull request
Mar 9, 2016
Implement callback stubbing APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66