0.5.14 broke web mocha adapter - not closing browser

[qubird]

My CI got broken after having updated testem to the latest version.
Tried with 0.5.15 as well and still broken.
With 0.5.5 browser processes get terminated and it works fine.

[airportyh]

Can you isolate it more? Is it fixed in 0.5.6? Was there an error message? What browsers were you running? By any chance are you running Opera?

[qubird]

Gets stuck on Chrome, not meant to run with opera. No error messages
spitted out, just hanging on with browsers window open I have run ver
0.5.15 and latest 0.6.x version with no luck.
On Jan 24, 2014 7:18 PM, "Toby Ho" notifications@github.com wrote:

Can you isolate it more? Is it fixed in 0.5.6? Was there an error message?
What browsers were you running? By any chance are you running Opera?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/336#issuecomment-33252222
.

[airportyh]

I am not able to reproduce, so I'll need more info. Can you isolate to a specific version of testem where it broke? We know it's between 0.5.5 and 0.5.15, yes?

[qubird]

I tried to run 0.5.15 and 0.6.5 without success. it works fine with 0.5.5
I will try to get more logging on monday and get back to you with more info.
Cheers

On Saturday, 25 January 2014, Toby Ho notifications@github.com wrote:

I am not able to reproduce, so I'll need more info. Can you isolate to a
specific version of testem where it broke? We know it's between 0.5.5 and
0.5.15, yes?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/336#issuecomment-33280127
.

[qubird]

I've run testem with --debug option, and this is the content of testem.log file:

node ~/node_modules/testem/testem.js ci -v --debug -t tests.html

version 0.6.5:

info Test'em starting...
info Seeking for config file...
info Starting ci
info Starting server
info spawning: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome - ["--user-data-dir=/tmp/testem.chrome","--no-default-browser-check","--no-first-run","http://localhost:7357/5398"]
info New client connected: Chrome 32.0 5398

version 0.5.15:

info Test'em starting... 
info Seeking for config file... 
info Starting ci 
info Starting server 
info spawning: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome - ["--user-data-dir=/tmp/testem.chrome","--no-default-browser-check","--no-first-run","http://localhost:7357/5398"] 
info New client connected: Chrome 32.0 5398 
{"level":"info","message":"Test'em starting...","timestamp":"2014-01-27T13:36:27.258Z"}
{"level":"info","message":"Seeking for config file...","timestamp":"2014-01-27T13:36:27.259Z"}
{"level":"info","message":"spawning: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome - [\"--user-data-dir=/tmp/testem.chrome\",\"--no-default-browser-check\",\"--no-first-run\",\"http://localhost:7357/353\"]","timestamp":"2014-01-27T13:36:27.401Z"}
{"level":"info","message":"New client connected: Chrome 32.0 353","timestamp":"2014-01-27T13:36:28.214Z"}

Tests are run into Chrome 32, but the browser never gets closed, therefore it hangs on indefinitely.

[airportyh]

What happens with 0.5.5? Could you isolate it down to a patch version where it stopped working? It would be a version between 0.5.5 and 0.5.15.

[qubird]

Last working version is 0.5.13

[airportyh]

Thanks! So the only commit that went into 0.5.14 was a fix to the mocha adapter. Are you using mocha?

[qubird]

yes I am

On 27 January 2014 16:09, Toby Ho notifications@github.com wrote:

Thanks! So the only commit that went into 0.5.14 was a fix to the mocha
adapter. Are you using mocha?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/336#issuecomment-33380877
.

[airportyh]

Okay, clearly an issue with the mocha adapter. What version of mocha do you have? Or are you using the version bundled with testem?

[qubird]

bundled version

[airportyh]

I still cannot reproduce this problem, probably requires a specific scenario. I believe the issue is in https://github.com/airportyh/testem/blob/master/public/testem/mocha_adapter.js - if you'd like to try your hand at debugging it. The other thing that would be helpful is if you can simplify our test case down to a gist that you can post here, then I can help you debug it.