[BUGFIX] Prevent leaked runners/sub processes. #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johanneswuerbach / @rwjblue / @krisselden r? |
|
Looks good to me, could you remove the |
stefanpenner
force-pushed
the
fix-leaky-runners
branch
2 times, most recently
from
977112b
to
79ea457
Compare
It is not uncommon during developer to end the process unexpectedly. Examples are <ctr-c>, crash, etc. Switching to `execa` gives us * automatic cleanup of child_processes in the above scenarios * Promise API * other nice things: https://github.com/sindresorhus/execa#why
stefanpenner
force-pushed
the
fix-leaky-runners
branch
from
79ea457
to
184de4e
Compare
|
The remaining Travis Task was OSX, which is having some trouble. Prior to dropping the lock file it was green, and I have now been waiting 1+ day for the job to be executed. Local test suggest all is well, as was the last CI run... So I am making the judgement call to skip it. |
|
@johanneswuerbach I believe we must release 2.x correct (as i see a previous commit changed the support matrix) ? Should I just do that now? |
|
@stefanpenner done, support about the delay. |
|
@johanneswuerbach nice thanks! |
|
@johanneswuerbach now that we support only newer node, any opposition to me modernizing the codebase? |
|
Definitely not! Happy to review any upcoming PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not uncommon during developer to end the process unexpectedly. Examples are , crash, etc.
Switching to
execagives us