Remove use of deprecated datetime.datetime methods
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods `datetime.datetime.utc` and `.utcfromtimestamp` were marked deprecated in Python 3.12 in favour of `now(tz=datetime.timezone.utc)` and `fromtimestamp(tz=datetime.timezone.utc)` [1]. [1]: python/cpython#103857
mtreinish
approved these changes
Sep 22, 2023
mtreinish
added a commit
to mtreinish/subunit
that referenced
this pull request
Nov 17, 2023
This commit adds explicit support and testing for Python 3.12 to python-subunit. Since testing-cabal#71 everything should be working fine when running python-subunit with 3.12, this commit adds CI tests to verify this on every commit and also marks 3.12 as explicitly supported in the trove classifiers in the package metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods
datetime.datetime.utcand.utcfromtimestampwere marked deprecated in Python 3.12 in favour ofnow(tz=datetime.timezone.utc)andfromtimestamp(tz=datetime.timezone.utc)1.The deprecation does note that there's a small slowdown from the newer methods, but it's on the order of a microsecond. I didn't change any of the use of
iso8601.UTCintodatetime.timezone.utc, but in practice theiso8601module just re-exports the standard-library object as its ownUTCobject.Footnotes
https://github.com/python/cpython/issues/103857 ↩