Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the description for several filesystem matchers. #228

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thomir
Copy link
Member

@thomir thomir commented Apr 15, 2016

This branch addresses issue #227: Several filesystem matchers have poor str methods, which means that failing assertions are often very hard to read.


This change is Reviewable

@thomir thomir changed the title Initial proof-of-concept to improve the output of filing matchers. Initial proof-of-concept to improve the output of failing matchers. Apr 25, 2016
@thomir thomir changed the title Initial proof-of-concept to improve the output of failing matchers. Improve the description for several filesystem matchers. May 1, 2016
@rbtcollins
Copy link
Member

So this feels a little icky to me, but meh, sure. At a minimum though, OverrideDescription needs tests.

Previously, thomir (Thomi Richards) wrote…

Improve the description for several filesystem matchers.

This branch addresses issue #227: Several filesystem matchers have poor str methods, which means that failing assertions are often very hard to read.


Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@thomir
Copy link
Member Author

thomir commented May 23, 2016

OK, when I get some spare time I'll add some tests.

If you can expand on 'icky' I'm happy to work up an alternate implementation that doesn't feel that way to you. I couldn't think of a better way to fix the problem, but perhaps you can?

@rbtcollins
Copy link
Member

I didn't have a better thing that wouldn't be hugely disruptive to hand;
was thinking perhaps we wanted a more data-container pattern:

>>> Not = MatcherType('Not(${1})', binary_matcher(operator.not))

or some such.

-Rob

@jelmer jelmer marked this pull request as draft March 9, 2021 15:08
@cclauss
Copy link
Contributor

cclauss commented Oct 18, 2023

Status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants