Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated assertRaisesRegexp with assertRaisesRegex #335

Merged
merged 3 commits into from Jun 6, 2022
Merged

Replace deprecated assertRaisesRegexp with assertRaisesRegex #335

merged 3 commits into from Jun 6, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jun 4, 2022 •
edited

I missed this in #319.

  • Python 3.1: assertRaisesRegexp was added (docs)
  • Python 3.2: Renamed to assertRaisesRegex and assertRaisesRegexp deprecated (docs)
  • Python 3.12: assertRaisesRegexp is planned for removal (PR) (originally planned for 3.11 but postponed)

Also:

  • Enable warnings in tests, so there's visibility for these (for example)
  • Fix "DeprecationWarning: Only valid in 1.8.1 and earlier. Use skipTest instead."

@cjwatson cjwatson merged commit df86fcb into testing-cabal:master Jun 6, 2022
@hugovk hugovk deleted the fix-assertRaisesRegexp-deprecation branch June 6, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwatson cjwatson cjwatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hugovk @cjwatson