Create assert_that function and use it from TestCase.assertThat. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow matchers to be used outside of the TestCase context. This is useful for people who can't buy in to testtools.TestCase fully (for whatever reason), or who like using function tests (as supported by nose).
|
Both @jml and @rbtcollins have indicated it's something that they'd be interested in, so I've updated the assertThat tests to be parameterised for both assert_that and assertThat, added some docs and a NEWS entry. |
|
I'm about to review the code; could you collapse this down to a series of semantic patches (vs an arc of exploration) after that? Thanks! |
| ------------ | ||
|
|
||
| * Introduce the assert_that function, which allows matchers to be used | ||
| independent of testtools.TestCase. (Daniel Watkins, #1243834) |
There was a problem hiding this comment.
This seems like an exaggeration: Matchers are already independent of TestCase; what this specifically does is provides a function based assert that uses Matchers.
|
Oh, and the move of tests is super hard to reason about; one way to make that easier might be to separate out the move-to-new-file and break-into-new-class steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow matchers to be used outside of the TestCase context. This is useful for people who can't buy in to testtools.TestCase fully (for whatever reason), or who like using function/generator tests (as supported by nose).
This isn't a full patch (and so shouldn't be merged as-is), but I wanted to get feedback on whether this approach would be acceptable before doing anything else.
Assuming it is acceptable, thoughts on how best to test it would be appreciated. My initial instinct was to modify all of the tests exercising the core behaviour I've extracted to point at
assert_thatand write some new tests to ensure thatassertThatconsumes theassert_thatAPI correctly.However, as we will be exposing essentially the same API in two places (
assert_thatandself.assertThat), I wonder if we should run the core-behaviour tests against both places by parameterising them somehow, so we're fully testing our public API. Thoughts appreciated.This will fix https://bugs.launchpad.net/testtools/+bug/1243834 (by providing the global function mentioned in the title).