fix: Pin supported target environment #1170
Conversation
There was a problem hiding this comment.
@eps1lon Pinning kcd-scripts won't help, as we're not using latest version yet (as I described in #1169 (comment))
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a06325d:
|
Codecov Report
@@ Coverage Diff @@
## main #1170 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 996 996
Branches 327 327
=========================================
Hits 996 996
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please see the PR title and description. I'm not pinning kcd-scripts but everything. |
eps1lon
force-pushed
the
fix/pin-tooling
branch
from
8108ad1
to
301ce55
Compare
eps1lon
force-pushed
the
fix/pin-tooling
branch
from
301ce55
to
3809120
Compare
eps1lon
changed the title
| "safari 15.5", | ||
| "samsung 17.0", | ||
| "samsung 16.0", | ||
| "node 12.0" |
There was a problem hiding this comment.
kcd-scripts does not use the engines field in its "--bundle" target. This is incorrect since it conflates the module entry with the browser entry. module and main are only for the used module system. Their runtime target needs to be the same. This isn't formally specified but conventionally used by bundlers (see https://esbuild.github.io/api/#main-fields).
|
🎉 This PR is included in version 8.18.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@eps1lon, it looks like CC: @timdeschryver |
What:
Closes #1169
Why:
A minor release created a build with that contained syntax that we don't support yet.
How:
Run
npx browserslist defaultswith a version ofcaniuse-litethat was used at the time of the latest good release.That snapshot is now contained in our manifest and ensures build tools transpile to this target.
Having "defaults" as the target environment is too weak of a contract to have.
Now it's apparent that changing the target environment is considered a breaking change.
We can decide in the next major release what a good matrix for supported runtimes is.
Checklist:
[ ]Documentation added to thedocs site
rm -rf node_modules/; npm install; npm run build, checkdist/@testing-library/dom.esm.js, no more??[ ]TypeScript definitions updated