Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: 10.0.0 #1269

Merged
merged 5 commits into from
Apr 8, 2024
Merged

release: 10.0.0 #1269

merged 5 commits into from
Apr 8, 2024

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 3, 2023 •
edited
Loading

10.0.0-alpha.2 (2023-10-03)

Bug Fixes

  • use defineProperty on the error object instead of setting the message directly (#1268) (3580f25), closes #1259

Features

BREAKING CHANGES

  • new version of aria-query changes various roles. Check out the changed tests in 2c57055 to get an overview about what changed.

10.0.0-alpha.1 (2023-09-10)

Bug Fixes

Features

BREAKING CHANGES

  • Minimum supported Node.js version is now 18.x

  • update node version in codesandbox

  • drop support for node 16 too

MatanBobi and others added 4 commits September 10, 2023 09:28
@MatanBobi
feat: Drop support for Node.js 14.x and Node.js 16.x and add support …
452097b 
…for Node 20.x (#1255)

* feat: Drop support for Node.js 14.x and add support for Node 20.x
BREAKING CHANGE: Minimum supported Node.js version is now 14.x

* update node version in codesandbox

* drop support for node 16 too
@jlp-craigmorten @eps1lon @MatanBobi
feat: upgrade aria-query to 5.3.0 (#1241)
2c57055 
* feat: upgrade aria-query to 5.3.0

* fix: correctly handle img with empty alt

* feat: pin `aria-query` version

* chore: add accessibility-alt-text-bot (#1240)

* chore: add accessibility-alt-text-bot

* fix formatting issues

* test: add coverage for footer to confirm it's expected implicit role as contentinfo

---------

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Matan Borenkraout <Matanbobi@gmail.com>
@eps1lon
fix: use defineProperty on the error object instead of setting the me…
3580f25 
…ssage directly (#1268)

Co-authored-by: Julien Wajsberg <felash@gmail.com>
Fixes #1259
@eps1lon
Merge branch 'main' into alpha
37ccada
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb57f99:

Sandbox Source
react-testing-library-examples Configuration

@eps1lon eps1lon marked this pull request as draft October 3, 2023 09:38
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #1269 (37ccada) into main (a7b7252) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1269   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1038      1041    +3     
  Branches       346       346           
=========================================
+ Hits          1038      1041    +3
Flag Coverage Δ
node-14 100.00% <100.00%> (ø)
node-16 100.00% <100.00%> (ø)
node-18 100.00% <100.00%> (ø)
node-20 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/role-helpers.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jlp-craigmorten
Copy link
Contributor

jlp-craigmorten commented Nov 11, 2023 •
edited
Loading

Is it worth adding to the release notes that #1241 also closes #1100, #1150, #1171, #1201, #1234, #1239?

@jlp-craigmorten jlp-craigmorten mentioned this pull request Feb 29, 2024
Merged
1 task
@kasperpeulen
Copy link

Any plans for when to release this? @eps1lon

@eps1lon
Copy link
Member Author

eps1lon commented Mar 11, 2024

@MatanBobi Started the release train but then real life happened so I don't think anybody is actively driving this.

@MatanBobi
Copy link
Member

Yeah, I indeed didn't get a chance to follow through on this release because I didn't have enough spare time.
We still want to test this release in some projects before releasing to see we're not missing anything regarding behavior changes.

@hannahpurcell hannahpurcell mentioned this pull request Mar 27, 2024
Merged
@MatanBobi
Copy link
Member

MatanBobi commented Apr 4, 2024 •
edited
Loading

I've ran some tests on a project I work on and they pass with no regression.
I'll mark this as ready for review and will try to push it soon.

@MatanBobi MatanBobi marked this pull request as ready for review April 4, 2024 07:44
timdeschryver
timdeschryver approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Fyi, This version didn't break a test in our case.

@eps1lon eps1lon mentioned this pull request Apr 8, 2024
Closed
@eps1lon
Copy link
Member Author

eps1lon commented Apr 8, 2024

RTL is green with DTL 10: testing-library/react-testing-library#1293

@eps1lon eps1lon merged commit 6ad31ec into main Apr 8, 2024
11 checks passed
@eps1lon eps1lon deleted the alpha branch April 8, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using an invalid selector, the error isn't processed properly by waitFor
5 participants
@eps1lon @jlp-craigmorten @kasperpeulen @MatanBobi @timdeschryver