Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-global-regexp-flag-in-query): check if empty name property node #566

Merged
merged 2 commits into from
Apr 4, 2022
Merged

fix(no-global-regexp-flag-in-query): check if empty name property node #566

merged 2 commits into from
Apr 4, 2022

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Apr 3, 2022

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list.
  • If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

  • check if the namePropertyNode var exists since it can be undefined.

Context

Closes #565

timdeschryver
timdeschryver previously approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, how did I miss that 😅
Thanks for fixing my mistake!

tests/lib/rules/no-global-regexp-flag-in-query.test.ts Outdated Show resolved Hide resolved
@Belco90 Belco90 merged commit 7f751e1 into main Apr 4, 2022
@Belco90 Belco90 deleted the 565_fix_no-global-regexp-flag-in-query_bug branch April 4, 2022 09:38
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

🎉 This PR is included in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

@MichaelDeBoey MichaelDeBoey Awaiting requested review from MichaelDeBoey

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-global-regexp-flag-in-query: TypeError 'value' of undefined
2 participants
@Belco90 @timdeschryver