Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-await-sync-events): add to DOM, Angular & React configs by default #667

Merged

Conversation

MichaelDeBoey
Copy link
Member

BREAKING CHANGE: no-await-sync-events is now enabled by default in the DOM, Angular & React configs


Closes #619

@MichaelDeBoey MichaelDeBoey added BREAKING CHANGE This change will require a major version bump v6 Next major v6 labels Oct 4, 2022
@MichaelDeBoey MichaelDeBoey self-assigned this Oct 4, 2022
@MichaelDeBoey MichaelDeBoey changed the base branch from main to alpha October 4, 2022 23:11
@skovy
Copy link
Collaborator

skovy commented Oct 5, 2022

should user event be removed from this rule since all methods are async (so there are no sync methods to incorrectly await)? I think the rule as it is may create false positives/negatives in user event v14?

@Belco90
Copy link
Member

Belco90 commented Oct 5, 2022

should user event be removed from this rule since all methods are async (so there are no sync methods to incorrectly await)? I think the rule as it is may create false positives/negatives in user event v14?

That's right. I think this was mentioned in another issue. Let me create a ticket for it in the v6 project.

@Belco90
Copy link
Member

Belco90 commented Oct 5, 2022

Issue for updating no-await-sync-events accordingly: #669

@timdeschryver
Copy link
Member

should user event be removed from this rule since all methods are async (so there are no sync methods to incorrectly await)? I think the rule as it is may create false positives/negatives in user event v14?

Makes sense to me.
Also, are the sync/async rules needed? There are specific linting rules that verify that promises are awaited and that non-promises are not awaited.

@MichaelDeBoey MichaelDeBoey changed the title Enable no await sync events in dom angular and react configs feat(no-await-sync-events): add to DOM, Angular & React configs by default Oct 5, 2022
…fault

BREAKING CHANGE: `no-await-sync-events` is now enabled by default in the DOM, Angular & React configs
@MichaelDeBoey MichaelDeBoey force-pushed the enable-no-await-sync-events-in-dom-angular-and-react-configs branch from b41a6d2 to 74658f4 Compare October 5, 2022 08:47
@Belco90
Copy link
Member

Belco90 commented Oct 5, 2022

Also, are the sync/async rules needed? There are specific linting rules that verify that promises are awaited and that non-promises are not awaited.

I guess you mean rules from TypeScript ESLint? If your codebase is written in TS, definitely the sync/async rules can be skipped. But if your codebase is written in JS, then those rules make sense.

@Belco90 Belco90 merged commit afce5ea into alpha Oct 5, 2022
@Belco90 Belco90 deleted the enable-no-await-sync-events-in-dom-angular-and-react-configs branch October 5, 2022 10:30
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

🎉 This PR is included in version 6.0.0-alpha.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump hacktoberfest-accepted released on @alpha released v6 Next major v6
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Enable no-await-sync-events in proper shareable configs
4 participants