-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace use of deprecated methods #925
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 96.23% 96.35% +0.11%
==========================================
Files 44 45 +1
Lines 2419 2470 +51
Branches 1000 1028 +28
==========================================
+ Hits 2328 2380 +52
+ Misses 91 90 -1 ☔ View full report in Codecov by Sentry. |
#926 proves that this works with ESLint v7, v8, and v9 so I think this should be safe to merge as-is and then we'll be one step closer to supporting ESLint v9 officially (the CI failure is just a flakey timeout - it should pass if rerun) |
@Belco90 @MichaelDeBoey would it be possible to get this and my follow-up PRs progressed, given that they can be released in a minor version? |
Checks
Changes
context
functions that were removed in v9 in favor of compat utilsContext
Resolves #924
Resolves #899