Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace use of deprecated methods #925

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Aug 14, 2024

Checks

Changes

  • introduced compat utilities that enable support for ESLint v9
  • replaced usages of context functions that were removed in v9 in favor of compat utils

Context

Resolves #924
Resolves #899

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (93a6ab9) to head (df12d17).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   96.23%   96.35%   +0.11%     
==========================================
  Files          44       45       +1     
  Lines        2419     2470      +51     
  Branches     1000     1028      +28     
==========================================
+ Hits         2328     2380      +52     
+ Misses         91       90       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath G-Rath changed the title feat: support ESLint v9 fix: replace use of deprecated methods Aug 14, 2024
@G-Rath
Copy link
Contributor Author

G-Rath commented Aug 14, 2024

#926 proves that this works with ESLint v7, v8, and v9 so I think this should be safe to merge as-is and then we'll be one step closer to supporting ESLint v9 officially

(the CI failure is just a flakey timeout - it should pass if rerun)

@G-Rath
Copy link
Contributor Author

G-Rath commented Sep 12, 2024

@Belco90 @MichaelDeBoey would it be possible to get this and my follow-up PRs progressed, given that they can be released in a minor version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint v9 - context.getScope is not a function - API change Prepare the rules for ESLint v9
1 participant