Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract each matcher's tests to its own test file #35

Merged
merged 2 commits into from
Jul 11, 2018

Conversation

gnapse
Copy link
Member

@gnapse gnapse commented Jul 11, 2018

What:

Separating the tests of each matcher, each into a file of its own.

Why:

The tests file is getting too big.

Checklist:

  • Ready to be merged

@gnapse gnapse self-assigned this Jul 11, 2018
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea 👍

Copy link
Collaborator

@smacpherson64 smacpherson64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, This is awesome!

@codecov-io
Copy link

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         100    100           
  Branches       20     20           
=====================================
  Hits          100    100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b764bc9...faf827f. Read the comment docs.

@gnapse gnapse merged commit 72bd9b5 into master Jul 11, 2018
@gnapse gnapse deleted the split-test-file-per-matcher branch July 11, 2018 14:47
@gnapse
Copy link
Member Author

gnapse commented Jul 11, 2018

🎉 This PR is included in version 1.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants