Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(svelte-testing-library): add FAQ entry for transition events #1363

Merged
merged 3 commits into from Feb 10, 2024

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Feb 3, 2024

Overview

Companion PR to testing-library/svelte-testing-library#311 to resolve testing-library/svelte-testing-library#206

Change log

  • Add FAQ entry for "Why aren't transition events running?"
  • Update "How do I test file upload?" with simpler solution based on user-event
  • Fix syntax issue in "Why isn't onMount called when rendering components?" snippet

Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit a40a4d5
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/65bdb15d546fc40008aacb29
😎 Deploy Preview https://deploy-preview-1363--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@yanick could you also review this please?

Copy link
Contributor

@yanick yanick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks groovy! 👍

@timdeschryver timdeschryver merged commit 2cd12ab into testing-library:main Feb 10, 2024
4 checks passed
@mcous mcous deleted the svelte-faq-transition branch February 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant waitFor dom changes introduced by on:introend
3 participants