Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove circular dependencies #1027

Merged
merged 2 commits into from
Aug 9, 2022
Merged

fix: remove circular dependencies #1027

merged 2 commits into from
Aug 9, 2022

Conversation

ph-fritsche
Copy link
Member

What:

Refactor code to remove circular dependencies.

Why:

Circular dependencies break imports in native CJS.

How:

Move functions that depend on our document/UI abstraction from utils into document or event.
Remove the System from Config and directly provide it on the Instance.
Use bound functions on the Instance to dispatch events.

Checklist:

  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a097d1:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1027 (7a097d1) into main (b6bbbd6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1027   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           85        88    +3     
  Lines         2076      2061   -15     
  Branches       702       691   -11     
=========================================
- Hits          2076      2061   -15     
Impacted Files Coverage Δ
src/event/behavior/registry.ts 100.00% <ø> (ø)
src/event/selection/resolveCaretPosition.ts 100.00% <ø> (ø)
src/setup/index.ts 100.00% <ø> (ø)
src/system/pointer/buttons.ts 100.00% <ø> (ø)
src/utils/dataTransfer/Clipboard.ts 100.00% <ø> (ø)
src/utils/focus/cursor.ts 100.00% <ø> (ø)
src/clipboard/copy.ts 100.00% <100.00%> (ø)
src/clipboard/cut.ts 100.00% <100.00%> (ø)
src/clipboard/paste.ts 100.00% <100.00%> (ø)
src/convenience/click.ts 100.00% <100.00%> (ø)
... and 49 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

🎉 This PR is included in version 14.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant