-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added listbox options support in selectOptions #473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid!
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 476 482 +6
Branches 132 134 +2
=========================================
+ Hits 476 482 +6
Continue to review full report at Codecov.
|
@all-contributors please add @luistak for tests |
I've put up a pull request to add @luistak! 🎉 |
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the |
🎉 This PR is included in version 12.1.10 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
What:
Added a few behaviors when selecting a
listbox
option toselectOptions
Why:
After adding the
role="option"
selector it was missing those behaviors to work as expectedHow:
Added those behaviors listed in this comment according to w3
Checklist: