Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added listbox options support in selectOptions #473

Merged
merged 7 commits into from Oct 22, 2020

Conversation

@luistak
Copy link
Collaborator

@luistak luistak commented Oct 21, 2020

What:

Added a few behaviors when selecting a listbox option to selectOptions

Why:

After adding the role="option" selector it was missing those behaviors to work as expected

How:

Added those behaviors listed in this comment according to w3

Checklist:

  • Documentation N/A
  • Tests N/A
  • Typings N/A
  • Ready to be merged
@luistak luistak requested a review from kentcdodds Oct 22, 2020
Copy link
Member

@kentcdodds kentcdodds left a comment

Solid!

@codecov
Copy link

@codecov codecov bot commented Oct 22, 2020

Codecov Report

Merging #473 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #473   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          476       482    +6     
  Branches       132       134    +2     
=========================================
+ Hits           476       482    +6     
Impacted Files Coverage Δ
src/select-options.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d19a65...508ef4b. Read the comment docs.

@kentcdodds kentcdodds merged commit 9d622f0 into testing-library:master Oct 22, 2020
3 checks passed
3 checks passed
codecov/patch 100.00% of diff hit (target 100.00%)
Details
codecov/project 100.00% (+0.00%) compared to 2d19a65
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Oct 22, 2020

@all-contributors please add @luistak for tests

@allcontributors
Copy link
Contributor

@allcontributors allcontributors bot commented Oct 22, 2020

@kentcdodds

I've put up a pull request to add @luistak! 🎉

@kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Oct 22, 2020

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@testing-library-bot
Copy link

@testing-library-bot testing-library-bot commented Oct 22, 2020

🎉 This PR is included in version 12.1.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@luistak luistak linked an issue that may be closed by this pull request Oct 22, 2020
jesujcastillom pushed a commit to jesujcastillom/user-event that referenced this pull request Oct 23, 2020
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.