Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The library doesn't seem to be working with firefox #18

Closed
suchitrak opened this issue Jun 14, 2021 · 7 comments · Fixed by #20
Closed

The library doesn't seem to be working with firefox #18

suchitrak opened this issue Jun 14, 2021 · 7 comments · Fixed by #20
Labels

Comments

@suchitrak
Copy link

I see the same issue as stated here:
testing-library/nightwatch-testing-library#31

[0-1] 2021-06-14T16:45:13.502Z ERROR webdriver: Request failed with status 500 due to javascript error: TypeError: window.TestingLibraryDom is undefined

@olivierwilkinson
Copy link
Collaborator

Thanks for raising this!

Just wanted to let you know that I'm working on this, I've got it running on Firefox successfully but there are other issues with the RegExp deserialisation (it seems)

I'll raise a PR once I've fixed that and have updated the test setup to include firefox so we can make sure this doesn't happen in future. 👍

@suchitrak
Copy link
Author

Thanks for the quick response.

@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@olivierwilkinson
Copy link
Collaborator

olivierwilkinson commented Jun 15, 2021

@suchitrak everything is working for me now 🥳. Please don't hestitate to let me know if you are still having issues with Firefox!

@suchitrak
Copy link
Author

Great! Thanks. I will try that today.

@suchitrak
Copy link
Author

Works on my end too. Thanks @olivierwilkinson

@olivierwilkinson
Copy link
Collaborator

No worries at all, thanks for raising it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants