Fix firefox #20
Merged
Fix firefox #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace chromedriver with the wdio selenium standalone service to support multiple drivers at once. Add Firefox to the wdio.conf.js capabilities
Evaluating the UMD script is not enough to add TestingLibraryDom to the window when running on Firefox. Add a script tag to the head element with the UMD inlined to add TestingLibraryDom to the window. Why it doesn't work is not clear to me right now so there may be a better way of fixing this. I'm assuming this is a security feature of Firefox but that is a guess.
DOM Testing Library uses instanceof to check whether a query is passed a RegExp, a Function or a string arg. For some reason on Firefox when a RegExp is passed to a query the `arg instanceof RegExp` check is always false, resulting in RegExp arguments being treated like a string. It appears that this is because the RegExp that is created in executeQuery is not the same class as that used in the instanceof check in DTL. I'm not sure exactly what could be causing it, it's possible that this is due to a polyfill or how we are adding DTL to the page, or something completely different. Assigning the RegExp that is in scope in executeQuery to window.RegExp seems to fix the problem, presumably because it overrides whatever modified RegExp class was added by the UMD script.
olivierwilkinson
force-pushed
the
fix-firefox
branch
from
78343a5
to
dede5a8
Compare
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18