headless=false #43
Merged
headless=false #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, the env var overrides from `rc` set strings, which aren't falsey - since your DISPLAY might be defaulting even an unset headless to `true`, you couldn't override it conveniently before
it now produces `Unable to locate package oracle-java8-set-default`
jkrems
approved these changes
May 17, 2019
.travis.yml
Outdated
| @@ -18,4 +17,5 @@ addons: | |||
| - ubuntu-toolchain-r-test | |||
| packages: | |||
| - g++-4.8 | |||
| - oracle-java8-set-default | |||
| before_install: | |||
There was a problem hiding this comment.
Do we still need this on node 8?
There was a problem hiding this comment.
Oh, which version started shipping npm6?
There was a problem hiding this comment.
looks like 8.12.0; will fix.
| if (config.get('chrome.headless', !process.env.DISPLAY)) { | ||
| args.push('--headless'); | ||
| } | ||
| var headlessCfg = config.get('chrome.headless', !process.env.DISPLAY); |
with 8.x > 8.12.0 we get npm6 preinstalled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the env var overrides from
rcset strings, which aren'tfalsey - since your DISPLAY might be defaulting even an unset headless
to
true, you couldn't override it conveniently before