Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headless=false #43

Merged
merged 4 commits into from May 17, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Expand Up @@ -6,4 +6,3 @@ test/tmp
examples/**/log
test/log
bin
/package-lock.json
18 changes: 8 additions & 10 deletions .travis.yml
@@ -1,15 +1,14 @@
language: node_js
node_js:
- '6'
- '8'
- '10'
- 8.16.0
- 10.15.3
deploy:
provider: script
script: ./node_modules/.bin/nlm release
skip_cleanup: true
'on':
branch: master
node: '8'
- provider: script
script: ./node_modules/.bin/nlm release
skip_cleanup: true
'on':
branch: master
node: 10.5.0
env:
- CXX=g++-4.8
addons:
Expand All @@ -18,4 +17,3 @@ addons:
- ubuntu-toolchain-r-test
packages:
- g++-4.8
- oracle-java8-set-default
5 changes: 2 additions & 3 deletions lib/processes.js
Expand Up @@ -130,9 +130,8 @@ function launchAllProcesses(config) {
'--disable-desktop-notifications'
];

if (config.get('chrome.headless', !process.env.DISPLAY)) {
args.push('--headless');
}
var headlessCfg = config.get('chrome.headless', !process.env.DISPLAY);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

if (headlessCfg && headlessCfg !== 'false') args.push('--headless');

if (config.has('desiredCapabilities.chromeOptions.args')) {
if (
Expand Down